IconClone Icon Exchange

miker1264 · 71647

miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #45 on: July 19, 2022, 06:22:51 PM
The x86 & the x86-64 versions are done.

And more importantly the AROS 68k version is done.  :)



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3762
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #46 on: July 19, 2022, 11:11:50 PM
Excellent !


Amiwell

  • Legendary Member
  • *****
    • Posts: 2616
    • Karma: +35/-4
  • Peace
Reply #47 on: July 20, 2022, 07:13:05 AM
thank you Miker :D



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #48 on: July 20, 2022, 02:07:50 PM
I was nearly finished with updates when I discovered a small display problem.

For PNG Icons there is no display problem. But for Amiga Classic Icons there was a big problem! After the Exchange the IconClone program attempts to display the Destination Icon but it fails to read the Classic Icon data to get the correct offset for the OS35 IFF Data.

I suspected I had done something to cause that but on closer inspection I saw that the Destination Icon had been changed. Specifically the do_Gadget.GadgetRender & do_Gadget.SelectRender had changed. But why? Did my program write bogus data to the file? No it didn't.

I suspected that there was a problem somewhere between GetDiskObject & PutDiskObject because that's basically what my Save_Icon function does. So I set up a simple test.

In Ram: I copied a good Classic Icon then set up a test function that only used GetDiskObject & PutDiskObject with no additions or changes. Surprise! The same changes happened again.

So my conclusion is that GetDiskObject/ PutDiskObject corrupts the resulting Classic Icon Data.

I will do some further testing perhaps with AROS One & AROS 68k to make sure that's the case.  8)




miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #49 on: July 20, 2022, 03:16:13 PM
An interesting solution would be this.

Since my function to get the offset to the IFF Data reads the Classic Icon File (E310) sequentially I can simply make it skip the offending data instead.  :)



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #50 on: July 21, 2022, 05:28:56 PM
I suppose I like to take the more difficult route.  8)

I'm currently writing a function to Save Classic Icons. It reads the source icon & writes a destination icon with diskobject data from the original & image data from source.

It's a lot of work but it is code I will need to use again later.

It will take a few days to make it work correctly.



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3762
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #51 on: July 21, 2022, 05:58:26 PM
Take your time, there is no hurry !


magorium

  • Legendary Member
  • *****
    • Posts: 634
    • Karma: +62/-0
  • Convicted non contributor
Reply #52 on: July 21, 2022, 06:44:34 PM
I was nearly finished with updates when I discovered a small display problem.
...
So my conclusion is that GetDiskObject/ PutDiskObject corrupts the resulting Classic Icon Data.
I wonder if that could be considered a bug of GetDiskObject/PutDiskObject ?

Does the same happen on classic m68k AmigaOS (with extended support for 3.5 icons ?)

On a side note:
why is this (still) reported in icaros desktop subforum (and not f.i. in software development) ?

Not in particular your doing miker but it is actually quite annoying to see every thread/subforum derailed with posts that don't belong to the sub-forum/topic. It makes finding posts back very difficult (amongst other things). You deserve at least the status/subforum of developing software  :)
« Last Edit: July 21, 2022, 06:55:25 PM by magorium »



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #53 on: July 21, 2022, 07:09:33 PM
Not sure yet.

I will start a new thread in Software Development.



paolone

  • Moderator
  • Legendary Member
  • *****
    • Posts: 569
    • Karma: +90/-0
Reply #54 on: September 13, 2022, 06:56:42 AM
Here is the x86 version of IconClone v1.0.7

It was tested on AROS One x86 v1.6 but not yet tested on IcarosDesktop.

It was built with my new Alt-ABIv0 Build System which is better than using gcc commandline.  ;)

For anyone interested I have also included in the zip file the source code for the current version of IconClone.


Many thanks


AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3762
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #55 on: September 13, 2022, 07:09:55 AM
Paolo the most recent is version 1.8 !


paolone

  • Moderator
  • Legendary Member
  • *****
    • Posts: 569
    • Karma: +90/-0
Reply #56 on: September 15, 2022, 02:27:53 AM
ok


Amiwell

  • Legendary Member
  • *****
    • Posts: 2616
    • Karma: +35/-4
  • Peace
Reply #57 on: September 16, 2022, 08:15:12 AM
Miker i have Icons for your program if you liked :)



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #58 on: September 16, 2022, 11:44:48 AM
Miker i have Icons for your program if you liked :)

That looks nice! I like the look of it.

I will be working on the next icon tool starting next week.  :)



Amiwell

  • Legendary Member
  • *****
    • Posts: 2616
    • Karma: +35/-4
  • Peace
Reply #59 on: September 16, 2022, 10:44:50 PM
ok miker