I was nearly finished with updates when I discovered a small display problem.
For PNG Icons there is no display problem. But for Amiga Classic Icons there was a big problem! After the Exchange the IconClone program attempts to display the Destination Icon but it fails to read the Classic Icon data to get the correct offset for the OS35 IFF Data.
I suspected I had done something to cause that but on closer inspection I saw that the Destination Icon had been changed. Specifically the do_Gadget.GadgetRender & do_Gadget.SelectRender had changed. But why? Did my program write bogus data to the file? No it didn't.
I suspected that there was a problem somewhere between GetDiskObject & PutDiskObject because that's basically what my Save_Icon function does. So I set up a simple test.
In Ram: I copied a good Classic Icon then set up a test function that only used GetDiskObject & PutDiskObject with no additions or changes. Surprise! The same changes happened again.
So my conclusion is that GetDiskObject/ PutDiskObject corrupts the resulting Classic Icon Data.
I will do some further testing perhaps with AROS One & AROS 68k to make sure that's the case.
