Wanderer Icon Exchange

[miker1264]

ìI'm planning to add a small menu system. One item will be to change type. It will likely use a numerical requester to choose the icon type.

Excellent

I will upload the latest version which will work as long as you use it from a script rather than drag-n-drop. I have issues with string pointers!

Here my English I think was not understood, the script I created to delete the message in the CLI, (CON: added .... Drag Icon into AppWindow)

P.S. IconClone you attached is the same as the one posted above, where the image change doesn't work

If you mean the version where drag-n-drop works correctly with exchange you will have to wait a while till I fix string pointer issues. I turned off the print messages. It's only for testing.

The string pointer issue is this: When you use the Requester Buttons each buttons calls GetSourceFilename or GetDestination. String pointer for srcename points to the source file and string pointer for destination points to destname.

But the problem with drag-n-drop is there's only one filename. Both srcename & destname point to the same filename. So I have to reorganize it and fix that part. But I don't have time till later today. Using the requesters works. Drag-n-drop not yet.

[AMIGASYSTEM]

Ok, I will wait for the new version, no rush, I had misunderstood me

As I said above I discovered that even the old Amiga icons can be replaced with your IconClone, to do this instead of loading the .info you have to load directly the file

[miker1264]

Ok, I will wait for the new version, no rush, I had misunderstood me

As I said above I discovered that even the old Amiga icons can be replaced with your IconClone, to do this instead of loading the .info you have to load directly the file

The older OS3.5 Icons can be used with IconClone to exchange images. But displaying the OS3.5 images is not yet implemented. That will be in the next updated binary hopefully.

I will need to rewrite some of the internal code to deal with the string pointers issue. One solution is to convert filename directly to disk object - srcedobj & destdobj to perform the exchange.

As far as getting a default icon image it has to find it using "SYS:". My system drive is "AROS1" but it still finds the default icon. You must have the def_Picture icon or the icon specified or it can't load the image.

[miker1264]

Back to my original plan. Because supporting drag-n-drop and using file requesters will cause a major re-write. I will split it into two projects - IconClone and IconDrop.

So IconClone will only use file requesters but no drag-n-drop. While IconDrop will only use drag-n-drop but no file requesters.

IconClone will have a small menu attached to decide what attributes to keep and to allow changing the icon type. It will also allow opening an unassociated file to assign an icon file.

IconDrop will be very simple. Drop the two icons then exchange.

I'm still undecided at this point. Maybe IconDrop will be experimental until I figure out how to make drag-n-drop work along with file requesters.

[AMIGASYSTEM]

Alright two is better than one

miker I don't know if you have ever noticed, on AROS with the icons happens a very strange thing that on Amiga doesn't exist, the icons change type automatically according to the file, example:

- Suppose we have a text file called "foo" with icon "Project" and the multiview tool, if we add that same icon to another file called "foo" but executable, the icon will automatically change to icon "Tool".

If we then add the same icon to a text file again, the icon will change back to a "Project" icon and the "multiview" tool setting will return.

This transformation also happens for Drawer Icon, Disk Icon etc..

If my English is not understandable I can create an exhaustive video

[miker1264]

Alright two is better than one

miker I don't know if you have ever noticed, on AROS with the icons happens a very strange thing that on Amiga doesn't exist, the icons change type automatically according to the file, example:

- Suppose we have a text file called "foo" with icon "Project" and the multiview tool, if we add that same icon to another file called "foo" but executable, the icon will automatically change to icon "Tool".

If we then add the same icon to a text file again, the icon will change back to a "Project" icon and the "multiview" tool setting will return.

This transformation also happens for Drawer Icon, Disk Icon etc..

If my English is not understandable I can create an exhaustive video

This may be due to defaults set in AROS Icon Library. An executable is automatically a "tool" and default tool (MultiView) is ignored. It may be the protection bits. I'm not sure. I'll check.

[new123]

Splitting of IconClone is a nonsense. You have a bug somewhere that need to be fixed! Put source code in GitHub or something, in my spare time I'll try to help.

[miker1264]

Splitting of IconClone is a nonsense. You have a bug somewhere that need to be fixed! Put source code in GitHub or something, in my spare time I'll try to help.

I agree. I'm trying to fix it now.

The problem is that I'm using STRPTR srcename & destname which works well with File Requesters. But when the user drops an icon there's only one filename. My solution is to go directly to GetDiskObject. I'm working on that part now.

[miker1264]

That worked. IconClone Drag-n-Drop is fixed.

Now it converts the filename directly to Disk Object whether it comes from drag-n-drop or file requester. Its fully functional. 

Next step is to add a small menu system to the user interface.

I hope we aren't having problems with ReqTools. I added an rtLong Requester to get "newicontype" by selecting menu item. The other menu items will be menu toggles for icon attributes.

I'm also adding support to display OS3.5 classic icon images. IconClone can Exchange OS3.5 Images as well as DualPNG.

[AMIGASYSTEM]

Thanks, as already said it will be an indispensable tool to love using Wanderer on AROS !

[miker1264]

Thanks, as already said it will be an indispensable tool to love using Wanderer on AROS !

For those who use Magellan they can already do Icon Exchange.

But for those of us who use Wanderer for AROS x86 & x86_64 there aren't many choices. But now we have a new icon tool. 

[AMIGASYSTEM]

As already said several times I have never used Magellan if not for testing, I like to stay in an Amiga environment, Dopus Magellan in my opinion is too dispersive and difficult to configure if you are not experienced users.

Recently on EAB has been opened a discussion Dopus4 vs Dopus5 where it is inferred that Dopus5 is not very appreciated by amigans.

https://eab.abime.net/showthread.php?p=1503647

[miker1264]

The drag-n-drop feature is working now as well as the file requesters.

Also when selecting the dest file that is an unassociated file with no icon it gets a real def icon.

[AMIGASYSTEM]

Ok drag-n-drop works fine with files, but it doesn't work with folder icons, the image swap works if you load the info file through the request.

I should add that a folder without an icon cannot have its image changed, probably because it does not use def_Drawer.info

Also found a very strange thing, after you have done a conversion with IconClone, if you click to activate an icon after a few seconds it automatically deactivates!

[miker1264]

Ok drag-n-drop works fine with files, but it doesn't work with folder icons, the image swap works if you load the info file through the request.

I should add that a folder without an icon cannot have its image changed, probably because it does not use def_Drawer.info

Also found a very strange thing, after you have done a conversion with IconClone, if you click to activate an icon after a few seconds it automatically deactivates!

These issues seem to be AROS One related.

It works well on IcarosDesktop 64bit and 32bit. I'll investigate.

I noticed that when dragging a folder icon from the filesystem that is associated with a folder it won't drop correctly.

But if you copy that same icon by itself into a test directory it will work with drag-n-drop just fine. Maybe it's a limitation of Wanderer?
Or perhaps Wanderer is trying to drop the file itself onto IconClone? I will do some more testing to find out for sure.

Hmmm...It seems to be an AROS 32bit limitation. You can't drag an associated icon using Magellan in IcarosDesktop 32bit either. It won't work.
But dragging an associated icon in IcarosDesktop 64bit works just fine. The mystery is getting deeper. 

P.S. - It seems that on AROS 32bit a trailing '/' is appended to the folder name whereas on AROS 64bit I assume there is no '/' just a file name. So I need to test for '/' and adjust my code.
Now we have to investigate what happens to real "def icons" on AROS 32bit. Maybe something similar is happening there. They don't work with the file requesters but they work on AROS 64bit.