Wanderer Icon Exchange

miker1264 · 17963

miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #90 on: December 23, 2021, 08:32:49 AM
Perfect miker, it works well even on AROS One x86, finally you can replace the icons on Wanderer x86, remains the problem Fonts "Ariel", with value 13 perfect no problem, with 15 problem on one side, with value 16 problem on two sides.

N.B. the Blue icons are folder icons of the new version of AROS One, I see that you use a very old version of AROS One :)

AMIGASYSTEM

Show me the font issue. Screenshots?

Describe the circumstances. AROS One 68k or x86 or both?

Is anyone else having a problem with GUI offsets when you change screen font to Arial 16? I tried it but don't see an issue.

Also in AROS One x86 older version Arial 16 isn't a problem.



« Last Edit: December 23, 2021, 08:57:33 AM by miker1264 »



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #91 on: December 23, 2021, 09:06:53 AM
I experience the same problem for both AROS One 68k and AROS One x86, the greater the size of the font, the greater the misalignment.

I attach 4 tests, with Arial 13 (perfect), 15, 16 and 20
« Last Edit: December 25, 2021, 03:39:34 PM by AMIGASYSTEM »



Amiwell

  • Legendary Member
  • *****
    • Posts: 2616
    • Karma: +35/-4
  • Peace
Reply #92 on: December 23, 2021, 09:35:47 AM
is the final release miker

Yes. This is the final release.

ok thank you Miker :)



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #93 on: December 23, 2021, 09:49:24 AM
I experience the same problem for both AROS One 68k and AROS One x86, the greater the size of the phon, the greater the misalignment.

I attach 4 tests, with Ariel 13 (perfect), 15, 16 and 20

Thank you. That helps to narrow down the issue.

Please do the same comparison for DTConvertGUI.

I'll try my alternate method by using struct TextAttr to assign a specific font to the gadgets independent of the screen font size.



« Last Edit: December 23, 2021, 09:53:18 AM by miker1264 »



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #94 on: December 23, 2021, 10:41:13 AM
I attach 4 tests DTConvertGUI, with Arial 13 (perfect), 15 (perfect), 16 and 20
« Last Edit: December 23, 2021, 11:53:31 AM by AMIGASYSTEM »



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #95 on: December 23, 2021, 11:15:21 AM
I attach 4 tests DTConvertGUI, with Arial 13 (perfect), 15 (perfect), 16 and 20

I have another idea. Instead of using fixed offsets I can use proportional offsets based on "ng_Width & ng_Height" of buttons. So then GadTools will provide scaling & offsets.

I believe I have the proportional offsets corrected for DTConvertGUI. It's the easier of the two. IconClone has GUI offsets as well as EraseRectangle coordinates to consider.

Now the gadget offsets are proportional to the screen font rather than fixed. In sequence from top: Arial 13, Arial 16, Arial 20. Someone will be pleased. I like Arial 16 now.  :D

New binaries to follow soon...

« Last Edit: December 23, 2021, 05:48:54 PM by miker1264 »



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #96 on: December 24, 2021, 05:23:49 PM
AMIGASYSTEM

Here is the x86 version of IconClone if you'd like to try it.

It uses proportional offsets based on screen font rather than fixed offsets.

I tested it with Arial 13, Arial 16, and Arial 20. This is the Christmas Edition.  ;)



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #97 on: December 24, 2021, 06:47:02 PM
A masterpiece, you made a nice Christmas present to AROS users who use Wanderer.

To the version with the drag and drop option you should add the ability to swap icons even for files that don't have an icon, this feature is present on all icon swapping programs.


miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #98 on: December 25, 2021, 10:23:10 PM
AMIGASYSTEM

Here is a new version just for you. I added a new function called Copy_Icon.

Now when you select the Destination it can be either an Icon or Unassociated File with no Icon.

If the file has no icon a temporary default icon will be copied to that location (def_Picture.info).

Then when you press the Exchange Button the new file with new images will be assigned to that file.






AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #99 on: December 26, 2021, 03:11:57 AM
I tested this version of IconClone but when I load a file without icon iconClone crashes, maybe I'm doing something wrong.

Probably CopyIcon uses another technique, from what I can guess it could be that CopyIcon copies the def_icon of the file without icon, I made a small video demonstration with CopyIcon

https://drive.google.com/file/d/1zZ2_v1l62_b0Cq6iiPaJu4YUFVlTJLxi/view?usp=sharing


new123

  • Newbie
  • *
    • Posts: 29
    • Karma: +38/-0
Reply #100 on: December 26, 2021, 10:29:18 AM
Big thank you, miker1264!

This is the tool I needed for a long time. In fact, I even started to code my own icon copier, but unfortunately haven't finished it. :(

Anyway... I tested your tool and everything seems to be fine except two things:

- lack of drag'n'drop (this is easy, check this https://eab.abime.net/showthread.php?t=101478)
- no support for classic icons (MagicWB, Newicons, etc.)



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #101 on: December 26, 2021, 10:38:48 AM
Big thank you, miker1264!

This is the tool I needed for a long time. In fact, I even started to code my own icon copier, but unfortunately haven't finished it. :(

Anyway... I tested your tool and everything seems to be fine except two things:

- lack of drag'n'drop (this is easy, check this https://eab.abime.net/showthread.php?t=101478)
- no support for classic icons (MagicWB, Newicons, etc.)

Those two items are on my ToDo List.  ;)

Did you get Drag-n-Drop to work on your icon copier?

I'm working on those two items. I'll release the source code also.

« Last Edit: December 26, 2021, 10:45:13 AM by miker1264 »



new123

  • Newbie
  • *
    • Posts: 29
    • Karma: +38/-0
Reply #102 on: December 26, 2021, 10:44:24 AM
Nice, good luck! :)



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #103 on: December 26, 2021, 10:47:36 AM
Nice, good luck! :)

How far did you get with the icon copier?

Mine is setup for OS3.5 Icons also but I haven't implemented the code to display the images. I will likely use INFO Datatype for it.




miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #104 on: December 26, 2021, 10:54:34 AM
I tested this version of IconClone but when I load a file without icon iconClone crashes, maybe I'm doing something wrong.

Probably CopyIcon uses another technique, from what I can guess it could be that CopyIcon copies the def_icon of the file without icon, I made a small video demonstration with CopyIcon

https://drive.google.com/file/d/1zZ2_v1l62_b0Cq6iiPaJu4YUFVlTJLxi/view?usp=sharing

Could you make a short video showing what you did to make it crash exactly so I can compare results & make adjustments?