AROS World Exec

Distros => Icaros Desktop => Topic started by: miker1264 on January 02, 2022, 05:54:40 PM

Title: IconClone Icon Exchange
Post by: miker1264 on January 02, 2022, 05:54:40 PM
Parsing of Classic Amiga Icons and IFFParse of OS3.5 Icon Data is now working!

IconClone can now load & display Amiga OS4.1 PowerIcons which are Classic Icon Files ( 0xE310 ) with ARGB Icon Chunks.

It can also load & display AROS Hybrid OS3.5 Icons which are also Classic Amiga Icon Files with ARGB Icon Chunks.

IconClone will also be able to load & exchange OS3.5 Glow Icon Images from Glow Icon to Glow Icon.  :)

You will also be able to click in the Icon Display Area to toggle the next icon image like a real icon.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 02, 2022, 05:59:34 PM
The original PNG screenshots are better to look at than the GIF.  ;)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 02, 2022, 06:01:25 PM
Here is the screenshot of the AROS Hybrid OS3.5 Icon Images.

The "New Icon Tools" is the package of small GUI & CLI based applications I'm working on for icons.

There are at least two more small GUI apps planned including "IconConvert" to convert OS4.1/AROS OS3.5 to PNG Icons and...
"IconSplit" which will split either PNG Icons, OS3.5 Icons, OS4.1 or AROS Hybrid Icons into either IFF-ILBM or PNG Images.

There will be several other small icon applications available as well when they are finished. I'm still writing & testing them.
On the list are also "IconColor" to use HSL ( Hue, Saturation, Luminance ) to change the color of icons "On-the-fly".

Also there is planned a GUI App called "IconProcess" to batch process the making of AROS Colored Icon Sets which can 
then be used with a GUI App called "ReplaceIcons" to change all the selected icons on the system to a new icon set.

ReplaceIcons is not going to be a script but rather a GUI based application to scan all the existing icons to generate an
"IconsList". It will use "Icon Alias List Processing" It will compare the IconsList to the NewIconsList from the icon set.
When it finds a name match it will replace the selected icon with the alternate icon from the new icon set. We need this app.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 02, 2022, 06:15:14 PM
More and more interesting, congratulations for being able to create such a beautiful and useful application!
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 02, 2022, 06:40:37 PM
More and more interesting, congratulations for being able to create such a beautiful and useful application!

Thanks.  :)
 
The way I work with these small applications is what I call the "Stepping Stone Method". Each is built upon the features of the one before it.

So it is beneficial to include as many "Novelties" as possible that can be used in the next iteration. Such as... being able to Display an Icon means we can convert OS4.1 PowerIcons to PNG Icons.
Title: Re: IconClone Icon Exchange
Post by: Amiwell on January 02, 2022, 06:42:16 PM
Great Miker :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 04, 2022, 11:52:10 PM
I had a crazy idea that i don't think any other Icon Exchange App does!

Because IconClone holds both the srcedobj (source disk object) & destdobj (destination disk object) in memory we can do something cool.  8)

                        if(reverse == TRUE)
                        {
                            reverse = FALSE; //reverse was true
                           srcedobj = destdobj; //switch disk objects, source is old destination
                           destfile = RemoveFileExtension(destname);
                            destdobj = GetDiskObject(destfile); //current destination icon
                            Exchange_Icon(destdobj, srcedobj, destname, deltasize, win);                        
                        }
                        else
                        {
                            reverse = TRUE; //reverse was false                           
                            Exchange_Icon(destdobj, srcedobj, destname, deltasize, win);
                        }

If you aren't satisfied after you have made the icon exchange and you would like to "Undo" simply double-click the Exchange Button and the Old Icon Reappears - magically.

The Exchange Button becomes a "Toggle" and you can change back and forth as much as you want. I got the idea by looking at the double arrow on the Exchange Button [ <-> ].
So with that in mind I thought "Shouldn't the exchange go in both directions according to the button?" So I changed a few things and tried it. And I was surprised that it worked.

This works great with AROS One x86 v1.6 to toggle the icon exchange. Remember to double-click the Exchange Button to Reverse the Icon Images. Have fun!
Each time Wanderer takes about one second to regenerate and refresh the icons in the window so be a little patient after pressing the Exchange Button.  :)


Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 05, 2022, 02:39:15 AM

If you aren't satisfied after you have made the icon exchange and you would like to "Undo" simply double-click the Exchange Button and the Old Icon Reappears - magically.


I'd say a great feature, I've had several times I've made a mistake and put the icons in the wrong place and done a reverse conversion and then couldn't go back :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 05, 2022, 08:54:41 AM

If you aren't satisfied after you have made the icon exchange and you would like to "Undo" simply double-click the Exchange Button and the Old Icon Reappears - magically.


I'd say a great feature, I've had several times I've made a mistake and put the icons in the wrong place and done a reverse conversion and then couldn't go back :)

Immensely popular feature for development also!  ;)

Now I don't have to keep copying new test icons after each test.Simply "Undo".

It also helped me find a problem. If I select the srce icon first then the dest icon then press "Exchange" it works as expected. But when I select dest icon first with drag-n-drop then select srce icon last then "Exchange" the images in the display area change but nothing happens to the original dest icon in the window. Why? It's because srcename & destname are both pointing to filename. That has all been resolved and it works nicely now.  :)


Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 07, 2022, 05:56:47 PM
The latest IconClone allows you to drop icons for drawers with custom icons or default icons for drawers with no icon file.

It also allows you to drop custom icons for files or default icons for files with no icon. Better yet if you don't like the images after you make the icon exchange simply press the exchange button again to "undo" exchange. The original destination icon returns.

It's a simple but elegant design. It should be very useful.

I plan to release the final AROS x86 version this weekend. I'll also place the binary and source code along with a small readme file on Aminet so others can try it.  :)

It has an AROS Public License.


Title: Re: IconClone Icon Exchange
Post by: Amiwell on January 07, 2022, 06:10:36 PM
Great Miker :D
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 08, 2022, 02:10:20 AM
Grazie miker, AROS One 68k e AROS One x86 aspettano con fiducia l'arrivo dell'ottimo software :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 08, 2022, 03:01:00 PM
Grazie miker, AROS One 68k e AROS One x86 aspettano con fiducia l'arrivo dell'ottimo software :)

You are welcome!

It has been tested on AROS One x86 v1.6. I haven't tested it for AROS 68K. But it should work there as well. We shall see.  ;)

Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 10, 2022, 12:47:40 AM
Here is the x86 version of IconClone v1.0.7

It was tested on AROS One x86 v1.6 but not yet tested on IcarosDesktop.

It was built with my new Alt-ABIv0 Build System which is better than using gcc commandline.  ;)

For anyone interested I have also included in the zip file the source code for the current version of IconClone.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 10, 2022, 02:57:29 AM
Outstanding, an indispensable tool for the management of icons before non-existent on Wanderer.

IconClone will be available in the upcoming new version 1.7 of AROS One x86, where in addition to many software updates also many new settings of Dopus4 and Wanderer, thanks Miker !

Given the importance of the software i made a news of IconClone v1.0.7 on Amiganews.it and eab.abime.net !

http://eab.abime.net/showthread.php?t=108451&page=2

https://www.amiganews.it/forum/viewtopic.php?t=21082
Title: Re: IconClone Icon Exchange
Post by: Amiwell on January 18, 2022, 05:57:37 AM
miker I found an icon for your program
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 16, 2022, 05:27:09 PM
@miker

I noticed on AROS One x86 that if an Icon includes a dot (.) in its name IconClone does not work, example:

Test.info -> It works
Test1.0 -> Does not work
Test 1.0 -> Does not work
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on April 04, 2022, 02:50:11 AM
miker I noticed that your IconClone also works perfectly with native OS4 icons, the only problem is that the icons are not shown in IconClone windows.

This compatibility is interesting, face I found out that PeterK's "ConvertPNGtoOS4" utility, perfectly converts my DualPNG icons to native OS4 icons.

For AfA One I also use "FakeIconSizeForAfA" which makes OS4 icons compatible on AfA OS :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on April 04, 2022, 09:50:04 AM
miker I noticed that your IconClone also works perfectly with native OS4 icons, the only problem is that the icons are not shown in IconClone windows.

This compatibility is interesting, face I found out that PeterK's "ConvertPNGtoOS4" utility, perfectly converts my DualPNG icons to native OS4 icons.

For AfA One I also use "FakeIconSizeForAfA" which makes OS4 icons compatible on AfA OS :)

That's a very interesting observation.

I hope that I can continue working on it soon.

I've been very busy with my work at home job.

Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 06, 2022, 11:18:13 AM
It has been about six months since I worked on this.
Hopefully I can start working on it again within a week.

Amiga Os3.5 GlowIcons & OS4.1 Icons will show correctly. I've written the code for that but I have yet to integrate it.

I was on a long break to do some work & house renovation. It's nice to see there has been some new activity with releases of Icarus desktop and AROS One & other distros.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 06, 2022, 11:29:01 AM
Hi miker, glad to hear from you again, will there be also an AROS 68k version ? at the moment on AROS 68k no icon changing App works anymore, including OS3 version !
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 06, 2022, 12:12:40 PM
Hi miker, glad to hear from you again, will there be also an AROS 68k version ? at the moment on AROS 68k no icon changing App works anymore, including OS3 version !

I will check that out for 68k when I get back into it. It should work there as well. I may have to tweak the user interface but the code should work when compiled for AROS 68k.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 07, 2022, 05:06:20 AM
Great and thank you
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 07, 2022, 03:36:21 PM
Great and thank you

I'm currently updating the display method using IffParse Library and IconControl from Icon Library to access the image data for Amiga Classic Icons such as GlowIcons and OS4 Powericons. The code is currently working in my test app. I just need to incorporate new functions into the main IconClone program.

It should be done in about two weeks. No hurry.  :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 07, 2022, 05:40:50 PM
Thank you and don't worry take your time there is no rush, we are in Summer and AROS One is going to the beach.




Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 07, 2022, 05:42:38 PM
One Question miker, in the new updated deadwood ISOs were your datatypes also included? I say this because I noticed that they work just as well as yours

Among the new features in the upcoming AROS One v1.8 will be the ability to choose between AmiStart and BoingIconBar, you will also be able to choose wallpapers and buttons all with a simple Click.

The only problem is on BoingIconBar which cannot be closed by a script, so a reboot will be required to install wallpapers and buttons.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 07, 2022, 06:25:15 PM
I'm not sure which datatypes are included in the newest release.

I have committed some updated datatypes to the repository. But there are some that I haven't included.

Other than PCX and TGA and TIFF which I'm still working on the major changes for the other datatypes are mostly done.

Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 07, 2022, 06:29:18 PM
Thank you and don't worry take your time there is no rush, we are in Summer and AROS One is going to the beach.

Yes. It's Summer and the temperature is rising here.
My air conditioner stopped working and it gets very hot in the evenings which is another reason I haven't worked on AROS projects much lately.

But the mornings are nice and cool.  8)

BTW - The test program code for IconClone is working to load OS4 icons & OS35 icons with ARGB data chunks!
Title: Re: IconClone Icon Exchange
Post by: Amiwell on July 09, 2022, 08:08:22 AM
Welcome back miker :D
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 09, 2022, 12:46:00 PM
Welcome back miker :D

Thanks salvo.

It's good to be writing and compiling and testing again.  :)
Title: Re: IconClone Icon Exchange
Post by: Amiwell on July 09, 2022, 12:48:13 PM
ok Miker Thank you :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 09, 2022, 12:55:55 PM
For IconClone version 1.08 I'm working on some updates.

It will be able to display OS35 or OS41 Icons or PNG Icons. It will also provide a visual clue of an icon style mismatch.

I'm currently working on a method to display OS35 icons. For example using IconControl from Icon Library I can get the planar image data from the GlowIcon. But in order to display it as a 32bit image like the others it has to be converted.

The function ReadOS35_by_datatype creates an empty ilbm datatype in memory. We then fill in the data such as values for the BMHD and CMAP. Then we copy the the planar image data to the bitplanes of the planar bitmap. As the last step we use ReadPixelArray to request 32bit ARGB data that can then be displayed in the raster port.

Whew! Sounds easy doesn't it ?
Title: Re: IconClone Icon Exchange
Post by: Amiwell on July 09, 2022, 01:07:38 PM
 :D
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 11, 2022, 01:46:51 PM
The test code for reading & displaying the OS35 GlowIcons is working!

It can also detect an Icon Style Mismatch between Source & Destination.

The visual clue for an Icon Mismatch will be to draw Red & White Colored Rectangles.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 11, 2022, 02:05:15 PM
Great !
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 11, 2022, 03:24:06 PM
These are a sample of the colored rectangles.

The Source is Red and Destination is White. This indicates an icon mismatch because the Source is an OS35 Hybrid icon with ARGB data chunk. And the destination is a PNG icon. Icon Library will simply display both equally well.

But if you're a purist and would like all of your icons the same you might want to know the difference. The way IconClone works is whichever icon style is in Source will be the resulting style for the icon exchange. So we want to make sure Source and Destination are the same such as both PNG Icons, both OS41 Icons or both OS35 icons.

If both icon styles match there won't be any rectangles.

Of course, if you don't mind, then exchange them as you like.  ;)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 11, 2022, 03:33:10 PM
Perfect, this is very important, it happens that some icons are strange and you can't tell which category they belong to !
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 12, 2022, 05:40:42 PM
Perfect, this is very important, it happens that some icons are strange and you can't tell which category they belong to !

Would it be better to have a message box explaining what each of the mismatched icons actually is ? Or just the colored rectangles as a visual clue ?

The message box will be in addition to the rectangles.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 12, 2022, 05:45:37 PM
Yes better the message, the rectangles might suggest some graphic artifacts
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 13, 2022, 06:46:56 PM
All the code for new features for IconClone is complete.

Now I just need to integrate the code into the new version of IconClone for testing and release.

I will plan to post the new version when it's ready on AROS Archives to replace the older version that is already there.
Title: Re: IconClone Icon Exchange
Post by: Amiwell on July 13, 2022, 07:37:20 PM
Thank you Miker :D
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 13, 2022, 08:48:28 PM
Thank you Miker :D

No problem.  :)

After IconClone is finished it will be available for AROS 68k, AROS x86 & AROS x86-64 all uploaded to AROS Archives.

The next small Icon App that I have planned is "IconMake" which will be an icon composer/converter. It will feature Drag-n-drop & it will also have two display areas. One on left & one on right. You can drop two icon images & choose Save As from the Menu to save one of several icon styles much like ilbm2icon.

Alternatively you can drop an entire icon & save each image independently or you can save as one of several icon styles. In that sense by dropping icons it acts as an icon converter.

It will be a fun but challenging project to work on.  :)

Eventually all the small icon apps will be part of an app launcher called "Icon Toolbox". Then we can launch any of the icon apps from the single ButtonBar Menu of Icon Toolbox. That should be a nice final icon project to bring it all together.

Each small icon app will also have a command line version so they can be used with scripts. IconClone for example could be used in that way to replace entire icon sets using a script.

Those are my plans so far.






Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 14, 2022, 01:03:37 AM
Great, this is what was needed on AROS for those who use Wanderer, the new App will also be very useful for those who use Magellan and Scalos.

The new IconClone Icon Exchange will be part of the upcoming release of AROS One v1.8, even more packed with new features  ;)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 16, 2022, 12:22:59 PM
Over the last few days I have incorporated the new code. It has been compiled for x86 & x86-64.

Over the next couple of days I will be testing the various versions including one for AROS 68k.

Hopefully by Monday IconClone version 1.08 will be ready to release.  :)
Title: Re: IconClone Icon Exchange
Post by: Amiwell on July 16, 2022, 02:22:02 PM
Thank you Miker :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 19, 2022, 06:22:51 PM
The x86 & the x86-64 versions are done.

And more importantly the AROS 68k version is done.  :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 19, 2022, 11:11:50 PM
Excellent !
Title: Re: IconClone Icon Exchange
Post by: Amiwell on July 20, 2022, 07:13:05 AM
thank you Miker :D
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 20, 2022, 02:07:50 PM
I was nearly finished with updates when I discovered a small display problem.

For PNG Icons there is no display problem. But for Amiga Classic Icons there was a big problem! After the Exchange the IconClone program attempts to display the Destination Icon but it fails to read the Classic Icon data to get the correct offset for the OS35 IFF Data.

I suspected I had done something to cause that but on closer inspection I saw that the Destination Icon had been changed. Specifically the do_Gadget.GadgetRender & do_Gadget.SelectRender had changed. But why? Did my program write bogus data to the file? No it didn't.

I suspected that there was a problem somewhere between GetDiskObject & PutDiskObject because that's basically what my Save_Icon function does. So I set up a simple test.

In Ram: I copied a good Classic Icon then set up a test function that only used GetDiskObject & PutDiskObject with no additions or changes. Surprise! The same changes happened again.

So my conclusion is that GetDiskObject/ PutDiskObject corrupts the resulting Classic Icon Data.

I will do some further testing perhaps with AROS One & AROS 68k to make sure that's the case.  8)

Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 20, 2022, 03:16:13 PM
An interesting solution would be this.

Since my function to get the offset to the IFF Data reads the Classic Icon File (E310) sequentially I can simply make it skip the offending data instead.  :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 21, 2022, 05:28:56 PM
I suppose I like to take the more difficult route.  8)

I'm currently writing a function to Save Classic Icons. It reads the source icon & writes a destination icon with diskobject data from the original & image data from source.

It's a lot of work but it is code I will need to use again later.

It will take a few days to make it work correctly.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on July 21, 2022, 05:58:26 PM
Take your time, there is no hurry !
Title: Re: IconClone Icon Exchange
Post by: magorium on July 21, 2022, 06:44:34 PM
I was nearly finished with updates when I discovered a small display problem.
...
So my conclusion is that GetDiskObject/ PutDiskObject corrupts the resulting Classic Icon Data.
I wonder if that could be considered a bug of GetDiskObject/PutDiskObject ?

Does the same happen on classic m68k AmigaOS (with extended support for 3.5 icons ?)

On a side note:
why is this (still) reported in icaros desktop subforum (and not f.i. in software development) ?

Not in particular your doing miker but it is actually quite annoying to see every thread/subforum derailed with posts that don't belong to the sub-forum/topic. It makes finding posts back very difficult (amongst other things). You deserve at least the status/subforum of developing software  :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on July 21, 2022, 07:09:33 PM
Not sure yet.

I will start a new thread in Software Development.
Title: Re: IconClone Icon Exchange
Post by: paolone on September 13, 2022, 06:56:42 AM
Here is the x86 version of IconClone v1.0.7

It was tested on AROS One x86 v1.6 but not yet tested on IcarosDesktop.

It was built with my new Alt-ABIv0 Build System which is better than using gcc commandline.  ;)

For anyone interested I have also included in the zip file the source code for the current version of IconClone.


Many thanks
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on September 13, 2022, 07:09:55 AM
Paolo the most recent is version 1.8 !
Title: Re: IconClone Icon Exchange
Post by: paolone on September 15, 2022, 02:27:53 AM
ok
Title: Re: IconClone Icon Exchange
Post by: Amiwell on September 16, 2022, 08:15:12 AM
Miker i have Icons for your program if you liked :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on September 16, 2022, 11:44:48 AM
Miker i have Icons for your program if you liked :)

That looks nice! I like the look of it.

I will be working on the next icon tool starting next week.  :)
Title: Re: IconClone Icon Exchange
Post by: Amiwell on September 16, 2022, 10:44:50 PM
ok miker
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on September 19, 2022, 03:21:35 AM
Hi miker, I noticed 2 problems with IconClone.

- If an icon has a dot (.) in its name, IconClone doesn't recognize it and if you try to swap image, IconClone crashes.

- If you have to swap multiple icons with one icon, strange things happen after the fourth icon

I attach a small demonstration video about the 2 problems.

https://drive.google.com/file/d/1ImKpCHYOfYitKpHOQx7DfG50VcLf7ULj/view?usp=sharing
Title: Re: IconClone Icon Exchange
Post by: miker1264 on September 24, 2022, 10:57:19 AM
Hi miker, I noticed 2 problems with IconClone.

- If an icon has a dot (.) in its name, IconClone doesn't recognize it and if you try to swap image, IconClone crashes.

- If you have to swap multiple icons with one icon, strange things happen after the fourth icon

I attach a small demonstration video about the 2 problems.

https://drive.google.com/file/d/1ImKpCHYOfYitKpHOQx7DfG50VcLf7ULj/view?usp=sharing

AMIGASYSTEM

Thanks for the report. I will work on fixing those issues.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on September 24, 2022, 12:39:00 PM
Yes thanks miker, take your time and when you have available time, I reported this problem because on AROS/Amiga there are many files that include "a dot", see audio file formats, video, text etc..
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on September 25, 2022, 04:33:00 AM
Sorry, i also encountered a problem with "Volume Icon" DH0, Ram etc....

This happens with both Native AROS and DualPNG icons, with Native AROS icons the image is corrupted, with DualPNG Icons on the other hand the image splits.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on September 25, 2022, 01:52:03 PM
AMIGASYSTEM

In this instance the problem is that these types of icons aren't fully supported. This looks like AROS 68k.

That will be fixed on the next version. That will be 1.9

Thanks for verifying the error though. I appreciate that.  :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on September 25, 2022, 02:10:07 PM
It is not a problem of icon type or graphic, any icon "if used as disk icon" creates that problem , the same icons if you use them as Tools or Project, stanamente do not have this problem.

Basically if you rename the disk icon and use it as a file or folder icon it works fine, see video:

https://drive.google.com/file/d/1GGSTCL4DWVPwLc2fIcAsdSUH6Uu5zE0e/view?usp=sharing
Title: Re: IconClone Icon Exchange
Post by: miker1264 on September 29, 2022, 11:20:11 AM
I can't view the AVI video.

I will download to my laptop later and try again. I'll do some testing also to verify.  :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on September 29, 2022, 12:08:13 PM
Strange, it's an MP4 file (Xivid), which you can see with MPlayer, of course first you have to unzip it is a ZIP archival
Title: Re: IconClone Icon Exchange
Post by: paolone on January 20, 2023, 08:38:25 AM
Hi Miker, may I ask you for a new feature? I'd love IconClone to accept som,e basic inline parameters, at least


IconClone source.info destination.info


that would make changing a icon from the shell a really quick job. Moreover, I'd use it to add a right menu item to Magellan, in order to "Change Icon" and have Dopus5 call iconclone to change the icon with whatever the user likes. It would be enough that running


IconClone source.info


opened IconClone with the selected source.info icon already open on the left, and let the user do the rest.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 20, 2023, 11:28:57 AM
@paolone

I'm starting my second set of revisions for IconClone.

I will modify the int main entry point to accept arguments.
Then it can be used with the GUI or by command line.

P.S. I'm working on my second icon tool called IconPress. The one after that will be IconSplit. Both work with DualPNG & Classic Icons (GlowIcons).  Join or Split either icon class.

All the icon tools will have a drag-n-drop interface. The command line can be used as well. Same as IconClone.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 21, 2023, 06:06:58 AM
miker did you receive my icons via PM ?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 21, 2023, 08:15:28 AM
miker did you receive my icons via PM ?

I downloaded them. Thanks.

I will take a look at them later today.

Did you mention that IconClone doesn't work with disk icons? What was the error?
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 21, 2023, 09:05:19 AM
I attach small comprehensive video !

https://drive.google.com/file/d/1JCOkG3Q3x9OyJo5O91aUKh4bqiT1o7hI/view?usp=share_link

Basically if you try to drag on the IconClone GUI a "Disk" Icon, be it DualPNG, but also AROS native Icons, the graphics will corrupt, if you then try to convert the system crashes !

I would add that among the new functions it would be very nice to have the possibility to change the icon type (Disk, Folder, Tools etc..) as well.

Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 21, 2023, 10:41:58 AM
I can't view the video on my phone.

Could you please attach the source icon & destination icon from the video that causes an error so I can examine them.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 21, 2023, 11:10:28 AM
Strange that your Phone does not see the video, it is a DivX gneric video format ! on AROS you will be able to see it without problems

I converted the video to a generic Phone Samsung format, try to see it, otherwise you tell me what Phone model you have, or I can put it on Youtube if your Phone supports it. !

It is easier to understand the problem with the video than to explain it :)

https://drive.google.com/file/d/16T578kSsnZu0UYsBYOfrRmV3ygLi9muf/view?usp=share_link
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 21, 2023, 11:42:16 AM
I viewed the video. Please attach the icons from the video so I can examine them.

Is it AROS x86 or 68k ? I suspect I know what the problem is.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 21, 2023, 11:59:30 AM
The problem is on AROS X86, but also AROS 68k, the corruption happens with any type of Icon as long as it is used as a "Disk" Icon, you can use the icons I sent you, or the native AROS Disk Icons, OS3 Glow, OS4, or S3 DualPNG.

You basically have to rename the Disk.info icon and copy it to the root of the disk, and then try to swap with othera disk icon
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 24, 2023, 05:28:46 PM
The problem is on AROS X86, but also AROS 68k, the corruption happens with any type of Icon as long as it is used as a "Disk" Icon, you can use the icons I sent you, or the native AROS Disk Icons, OS3 Glow, OS4, or S3 DualPNG.

You basically have to rename the Disk.info icon and copy it to the root of the disk, and then try to swap with othera disk icon

Thanks for the information. I will try to reproduce the error then correct it. I will examine the icon exchange for Disk.info & Ram Disk: as well as the icons for "leave out".

I have started adding the command line arguments & switches. The code requires quite a lot of re-writing for it to work correctly. So far I can send it one or two icon filenames with the -o switch which tells IconClone to open the GUI & display the icon(s). There are two command switches -h (help) & -o (open).

These are the planned command sequences: send it icon filenames with -h displays help. Send it two icon filenames without switches will perform the icon exchange without opening the GUI. Send it one or two icon filenames with -o switch will open the GUI & it will display one or two icons.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 24, 2023, 05:34:48 PM
Thanks to you, the most important options are to change the type of Icons, on AROS unfortunately there is nothing that can do that, it can only be done if you use Dopus5, but I don't care about Dopus5.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 24, 2023, 05:43:00 PM
Thanks to you, the most important options are to change the type of Icons, on AROS unfortunately there is nothing that can do that, it can only be done if you use Dopus5, but I don't care about Dopus5.

There is another icon tool that is planned to do that. It is simply called IconType. We can easily change icon type for Classic Icons. But for DualPNG Icons that information resides in the ic0n chunk. I've already started that app.  :)

These small icon tools will all be combined in Icon ToolKit which will be a single app with a button menu. You will be able to select several icon tools from the menu buttons.

The icon tools for the menu buttons so far are: IconClone, IconPress, IconSplit, IconColor, IconProcess & IconType.



Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 24, 2023, 05:49:00 PM
Yes you had mentioned it before, moreover it is very important when an application does not start because the icon is wrong, for example DualPNG "Tools" icons that I create on AfA One with 3.9, on OS 3.2 are seen as "Project" icons
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 24, 2023, 06:16:03 PM
Yes you had mentioned it before, moreover it is very important when an application does not start because the icon is wrong, for example DualPNG "Tools" icons that I create on AfA One with 3.9, on OS 3.2 are seen as "Project" icons

If you send me some icon samples I can examine them & use them for testing.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 24, 2023, 06:28:16 PM
It happens occasionally with Icons created for AROS One, but I have never delved into it to look for who is creating the problem, whether AROS or AfA One, next time it happens I will send you an icon.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 26, 2023, 11:39:55 AM
This is my conceptual layout for Icon ToolKit App Launcher.

Each of the Button Menu items on the right side launches a Small Icon App such as IconClone that I'm developing now.

Each Icon App has it's own icon in the same directory as Icon Toolkit so they can also be started independently.

Additionally each Icon App features drag-n-drop and they will have command line arguments and switches as well.

The Button Menu App Launcher can be used to start any external application. Just change the logo & window title. The Button text & app paths can be modified as needed.

The App Launcher source code will be posted when done.

Title: Re: IconClone Icon Exchange
Post by: Amiwell on January 26, 2023, 12:08:51 PM
very nice Miker :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 26, 2023, 12:11:45 PM
Outstanding Miker, the fact that the GUI can be realized will be very useful !
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 27, 2023, 03:10:41 PM
AMIGASYSTEM

As far as loading & exchanging icons such as "disk.info" here are the test results.

When on Workbench you drag the AROS icon or Ram Disk icon & drop it in IconClone nothing will display. But why?

The filenames are "AROS:" & "Ram Disk:" because these are volume names. For IconClone I will test for filenames ending with ':' which will then pop up a message. We can't load Volume icons directly because they aren't where we expect them to be. "Left Out" icons such as Dopus4 seem to load just fine. Though dragging icons sometimes causes image distortion.

On the other hand I know where the Volume icons are located. So I could just substitute the filenames. AROS: is actually AROS:disk.info. Same for Ram Disk: icon location. Also these icons on Workbench won't change till system reboot.

AROS icon for example is located in the root of "AROS:" volume. Even when you select "All Files" you can't see it. Disk.info is hidden. You can now use the shell command "IconClone --o AROS:disk.info" to open the GUI to load it. Alternatively you can use the '?' File Requester Buttons. "Ram Disk:" icon is located in AROS:Prefs/Env-Archive/SYS/def_Ram.info. If you specify these locations in CLI or go there you can load the icons.

The CLI Arguments & Switches are working now.  :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 27, 2023, 05:32:01 PM
Thanks for the explanations, if it is of interest to you, on OS3 and OS4 the Disk Icons can be swapped quietly from the Workbench
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 29, 2023, 05:12:25 AM
Also for Disk Icons, AROS x86 with Dual-PNG Icons behaves strangely:

Any Project icon if copied to the root of the disk, automatically turns into a "Disk" Icon, vice versa if you copy the same icon to a folder it goes back to being a "Project" icon, see screenshot

All this does not happen with Native AROS icons :o
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 29, 2023, 11:44:16 AM
AMIGASYSTEM

Thanks for the information. I will investigate that issue.

In the meantime IconClone has been revised to version 1.10 which will be posted on AROS Archives in the next few days

Work on the next icon tool is going well. It's called IconPress because it "presses" (joins) two images into an icon file. It does what ilbmtoicon does but in a more meaningful & user-friendly way.  :)

Simply drop either two PNG images or two ILBM images in the two Display Areas on Left & Right. There are two buttons. "Save Icon" will save a PNG icon if both images are PNG. It will save a Classic Amiga Icon with OS35 Extension if both images are ILBM. "Save Argb" only works will PNG input images. It will save Classic Amiga Icon with OS35 Extension with Argb data chunks. For example Gorilla Icons are Classic Icons with Argb data chunks.

IconPress uses Neuquant Color Quantizing to reduce the 32bit PNG images to ILBM images with 8 bitplanes to be stored in the OS35 IFF Data. This image conversion is the basis for two small command line apps for AROS that I will write called icon_to_os4 (PNG to OS4.1) & os4_to_icon (OS4.1 to PNG). As far as splitting icons I'm working on two other small command line utilities icon2png (split PNG icon) & icon2iff (split Classic OS35 icon). DT2IFF already reduces a 32bit PNG to 8bit ILBM. All these small utilities will be posted to AROS Archives as well with source code

As mentioned earlier IconClone, IconPress, IconSplit, IconBatch, IconType & IconColor are all small icon apps that will be part of Icon ToolKit. They will also work as standalone icon apps. That's the plan.  ;)

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 29, 2023, 11:48:28 AM
AMIGASYSTEM

Thanks for the information. I will investigate that issue.

In the meantime IconClone has been revised to version 1.10 which will be posted on AROS Archives in the next few days

Work on the next icon tool is going well. It's called IconPress because it "presses" (joins) two images into an icon file. It does what ilbmtoicon does but in a more meaningful & user-friendly way.  :)

Simply drop either two PNG images or two ILBM images in the two Display Areas on Left & Right. There are two buttons. "Save Icon" will save a PNG icon if both images are PNG. It will save a Classic Amiga Icon with OS35 Extension if both images are ILBM. "Save Argb" only works will PNG input images. It will save Classic Amiga Icon with OS35 Extension with Argb data chunks. For example Gorilla Icons are Classic Icons with Argb data chunks.

IconPress uses Neuquant Color Quantizing to reduce the 32bit PNG images to ILBM images with 8 bitplanes to be stored in the OS35 IFF Data. This image conversion is the basis for two small command line apps for AROS that I will write called icon_to_os4 (PNG to OS4.1) & os4_to_icon (OS4.1 to PNG). As far as splitting icons I'm working on two other small command line utilities icon2png (split PNG icon) & icon2iff (split Classic OS35 icon). DT2IFF already reduces a 32bit PNG to 8bit ILBM. All these small utilities will be posted to AROS Archives as well with source code

As mentioned earlier IconClone, IconPress, IconSplit, IconBatch, IconType & IconColor are all small icon apps that will be part of Icon ToolKit. They will also work as standalone icon apps. That's the plan.  ;)

Great job, this will also be useful for users who like the old Glow Icons of OS 3.9 and OS 3.2
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 29, 2023, 12:21:08 PM
AMIGASYSTEM

Thanks for the information. I will investigate that issue.

In the meantime IconClone has been revised to version 1.10 which will be posted on AROS Archives in the next few days

Work on the next icon tool is going well. It's called IconPress because it "presses" (joins) two images into an icon file. It does what ilbmtoicon does but in a more meaningful & user-friendly way.  :)

Simply drop either two PNG images or two ILBM images in the two Display Areas on Left & Right. There are two buttons. "Save Icon" will save a PNG icon if both images are PNG. It will save a Classic Amiga Icon with OS35 Extension if both images are ILBM. "Save Argb" only works will PNG input images. It will save Classic Amiga Icon with OS35 Extension with Argb data chunks. For example Gorilla Icons are Classic Icons with Argb data chunks.

IconPress uses Neuquant Color Quantizing to reduce the 32bit PNG images to ILBM images with 8 bitplanes to be stored in the OS35 IFF Data. This image conversion is the basis for two small command line apps for AROS that I will write called icon_to_os4 (PNG to OS4.1) & os4_to_icon (OS4.1 to PNG). As far as splitting icons I'm working on two other small command line utilities icon2png (split PNG icon) & icon2iff (split Classic OS35 icon). DT2IFF already reduces a 32bit PNG to 8bit ILBM. All these small utilities will be posted to AROS Archives as well with source code

As mentioned earlier IconClone, IconPress, IconSplit, IconBatch, IconType & IconColor are all small icon apps that will be part of Icon ToolKit. They will also work as standalone icon apps. That's the plan.  ;)

Great job, this will also be useful for users who like the old Glow Icons of OS 3.9 and OS 3.2

Perhaps another small icon app  "os35_to_icon" (ILBM to 32bit PNG) ? Then you convert GlowIcons to DualPNG.

But of course the original quality determines the output.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 29, 2023, 12:42:43 PM
I don't know I have never created Glow icons in OS 3.9 style!
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 31, 2023, 05:33:48 PM
Also for Disk Icons, AROS x86 with Dual-PNG Icons behaves strangely:

Any Project icon if copied to the root of the disk, automatically turns into a "Disk" Icon, vice versa if you copy the same icon to a folder it goes back to being a "Project" icon, see screenshot

All this does not happen with Native AROS icons :o

The strange behavior is probably due to the fact that PNG icons don't store the IconType in the icon data like a Classic Amiga Icon. Instead the icon attributes are stored in the ic0n chunk.

Do you get the same behavior on Wanderer & Dopus4 ?
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on January 31, 2023, 06:24:57 PM
As shown in the first screenshot I had posted earlier, the difference from Disk Icon to project icon is really noticeable with Dopus4

On Wanderer "it all depends on its filename," see screenshot

- If a DualPNG icon is named "Disk.info" it will be a Disk Icon.
- If we rename the same Icon "Disk2.info" or other name, it will become a Project Icon

On AfA OS the Dual PNG Icons do not have this problem, a Disk Icon will remain a Disk Icon even if renamed.

On OS 3.9, on the other hand, if a DualPNG icon "Disk.info" is renamed "Disk2.info," it will become a Tools Icon
Title: Re: IconClone Icon Exchange
Post by: miker1264 on January 31, 2023, 07:03:38 PM
I don't fully understand how all the icon data is stored in the ic0n chunk in PNG icons. Specifically I'm not sure Icon Library hard codes the icon type attribute in ic0n chunk.

According to Icon Library code if type = 0 it will deduce the icon type based on several criteria.

To better see exactly what data is in the icon files I'm writing a small tool 'IconInfo' that will list at the command line everything about Classic Icons & PNG icons.

So then I will know if Wanderer is not being truthful.  ;)

So far I looked at the icOn chunk data for about ten PNG icons. The results are surprising!

None had Icon Type defined in the attributes. Drawer icons had some drawer data & stacksize = 4096 & frameless whatever that is. Project icons had stacksize, frameless, iconx, icony & defaultool defined. Strangely, disk.info only had drawer data, stacksize, frameless & two tooltypes. It looks like a drawer icon.

Title: Re: IconClone Icon Exchange
Post by: magorium on February 02, 2023, 05:26:31 AM
@miker:
Craps, I totally forgot about this. My Apologies.

From memory thus afaik (I'll dig up my code) the 'settings' in the icon chunk are stored as tags. AROS uses a set of default tag-values in case the icon chunk does not contain them or one is not present.

edit: found my code (icon chunk indeed contains tags). You got a PM miker1264  :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 02, 2023, 01:46:53 PM
@miker:
Craps, I totally forgot about this. My Apologies.

From memory thus afaik (I'll dig up my code) the 'settings' in the icon chunk are stored as tags. AROS uses a set of default tag-values in case the icon chunk does not contain them or one is not present.

edit: found my code (icon chunk indeed contains tags). You got a PM miker1264  :)

Thanks for the information. It's good that you reminded me that a char array ends with null char.

Reading the ULONG tag ID's wasn't difficult. But I was trying to find an easy way to read Defaultool & Tooltypes.

When I find the tag ID for Defaultool for example I can just read the remainder of the icon chunk into UBYTE *chunk data. Then value = (char *)chunk data. And length of string is strlen(value). Something like that.  :)

But I will need to work with the icOn chunk in a later project
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 02, 2023, 05:27:58 PM
Ha! Now IconClone can load & display Volume Disk Icons.

It wasn't easy to work out how to get the correct icon filename.

I'm wondering if volume disk icon names are case sensitive? Is "Disk.info" the same as "disk.info" ?
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 02, 2023, 06:25:56 PM
Disk.info, disk.info, DISK.INFO, nothing changes, we are on AMiGA no Linux :D

When will the new version of IconClone be available?
Title: Re: IconClone Icon Exchange
Post by: magorium on February 03, 2023, 12:28:40 AM
Thanks for the information. It's good that you reminded me that a char array ends with null char.
You're welcome. Hopefully it was helpful (as i PM'ed you quite some long detailed technical boring crap)

Quote
Reading the ULONG tag ID's wasn't difficult. But I was trying to find an easy way to read Defaultool & Tooltypes.
The tool-types is/was a bit tricky for me as well. Once you got these reading correctly then all else in the icon chunk false into place (automatically) except for those tags that your current code-base does not support yet (but can then easily be added).

Quote
But I will need to work with the icOn chunk in a later project
Then it is indeed better to tackle this format in an early stage.

Unfortunately the format itself leaves a lot desired as it involves a lot of if/then checks in order to be able to determine the actual/correct icon type.

Any hows: If you have more questions or run into bumps in the road or you simply wish to check your progress then feel free to make a shout. we could always compare/check our tools (and perhaps I have mistakes in there as well so we could compare notes).
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 03, 2023, 11:52:15 AM
@magorium

Thanks. I'm using diskobjPNGio.c  function ReadIconPNG as a guide. I'm only using the attr defines. I'm reading the ULONG tag ID's directly. Reading the icOn chunk & listing it's contents is for a new small command line app IconInfo which lists all the icon attributes & other data for Classic Amiga Icons, ARGB Icons including OS4.1 Icons & AROS PNG Icons.

I'm just finishing up the new features for IconClone.

@paolone
It now has command line arguments & switches. I will add the syntax for those in the readme file.

It also now supports loading & displaying single image Gorilla Icons for AROS 68k. It also supports loading & displaying Volume Disk Icons (Disk.info).

If you change the icon images for a Disk Icon on Workbench a system restart is required for the visual changes to take place. Remember that if you exchange images for Ram:Disk.info if you want changes to be permanent you must also change the def_Ram icon in Presets/Env-Archive/SYS.



Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 03, 2023, 12:02:59 PM
miker, for swapping the DiskInfo.info, but also other System Icons you don't need to reboot the system, just do a refresh of Wanderer.

On AROS to my knowledge there is no refresh command , but you can refresh Wander simply by using the command "Wanderer Backdrop"
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 03, 2023, 12:26:44 PM
miker, for swapping the DiskInfo.info, but also other System Icons you don't need to reboot the system, just do a refresh of Wanderer.

On AROS to my knowledge there is no refresh command , but you can refresh Wander simply by using the command "Wanderer Backdrop"

Very nice.  :)

I assumed there was a way to do that but I wasn't sure about how to do it. There may be a similar feature for Magellan to redisplay the Workbench.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 03, 2023, 12:43:05 PM
No on Magellan, "Opus Backdrop" does not refresh the Workbench.

AmiStart also has a Refresh but it only works on its bar.

I think it should not be difficult to create a small command to do a Workbench Refresh, if any developer would like to do it we would be very grateful.

I will do some research if there is any source or OS3 script that can be adapted


EDIT:

Found on Aminet "SmartW" C-Source is included.
Tried to compile on AROS x86 it but I get compile errors

http://aminet.net/package/dev/src/SmartWB10
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 03, 2023, 03:50:22 PM
No on Magellan, "Opus Backdrop" does not refresh the Workbench.

AmiStart also has a Refresh but it only works on its bar.

I think it should not be difficult to create a small command to do a Workbench Refresh, if any developer would like to do it we would be very grateful.

I will do some research if there is any source or OS3 script that can be adapted


EDIT:

Found on Aminet "SmartW" C-Source is included.
Tried to compile on AROS x86 it but I get compile errors

http://aminet.net/package/dev/src/SmartWB10

IconClone works wonderfully on AROS One x86.

Thanks to @paolone for requesting the command line options.

The Wanderer Backdrop works well to refresh.  :)

This is what I did for testing. If you are going to be changing  volume disk icons and you are unsure just copy AROS:Disk.info to AROS:Extras or anywhere that isn't a volume.

Simply go to AROS:Tools or wherever IconClone is located. Launch the program with the app icon or open a shell and type IconClone --o please note there are two dashes and that is the small letter 'o' not the number zero. The empty GUI should open on Workbench. More about that in a few.

Drop the AROS: icon in the destination display area on the right. Drop another icon, such as Ram: like I did, on the source display area on the left. Then perform the exchange.

Do the Wanderer Backdrop trip and the disk icon images change to the new ones. To restore the disk icon from backup do this. In a shell type IconClone --o AROS:Extras/Disk.info to open the original disk icon in the source display area on the left. Note that disk.info isn't visible in ICON VIEW. It's hidden from view. Drop your now changed AROS: icon on the destination display area and perform the exchange. After the backdrop trick it re-appears and the icon has been restored.  ;)

If you prefer to do it all at once to restore the disk icon since we know the locations, in the shell type IconClone --o AROS:Extras/disk.info AROS:Disk.info and the GUI opens and both icons are displayed. Just press the exchange button.

Beware though if we leave out the --o the command is IconClone AROS:Extras/disk.info AROS:Disk.info. This is the command line exchange for scripts. There are no prompts or messages. It simply exchanges the icons with no GUI.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 04, 2023, 03:48:57 PM
Thanks miker although I don't like Shell commands very much, I will probably use these commands from Dopus4.

Last night on amigans.net I created some OS 4.1 style icons for old Amiga games (see screenshot) to an OS4.1 users, see attached link, and I received compliments for the speed and quality of the created icons !
... and to think that a few years ago I had no idea how to create a DualPNG/PowerIcons OS4 Icon

https://www.amigans.net/modules/newbb/viewtopic.php?topic_id=9148
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 04, 2023, 04:22:55 PM
Thanks miker although I don't like Shell commands very much, I will probably use these commands from Dopus4.

Last night on amigans.net I created some OS 4.1 style icons for old Amiga games (see screenshot) to an OS4.1 users, see attached link, and I received compliments for the speed and quality of the created icons !
... and to think that a few years ago I had no idea how to create a DualPNG/PowerIcons OS4 Icon

https://www.amigans.net/modules/newbb/viewtopic.php?topic_id=9148

Very nice work.  :)

Having more icon tools to assemble or disassemble icons or to add special effects is an advantage. I'm working on several tools myself.

I haven't succeeded in adding a glow border to an image using my tools. But I can change the neon gold to neon blue or neon green glow border using HSL Color Shifting.

Recently I've been discovering the secrets of the icon attributes stored in the PNG icOn chunk. Some DualPNG Icons have two icOn chunks curiously. I only need to find the offset & length of the icOn chunk for use with my tools.

However when working on IconType it will be convenient to be able to list all the attribute tags to see if a new "type" was added. For IconType I may simply use DiskObjects.




Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 04, 2023, 04:40:36 PM
Great, I will be happy to include it on AROS One 2.0 !

Question, do you know what tool the AROS x86 build Icons were created with?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 04, 2023, 05:55:55 PM
Great, I will be happy to include it on AROS One 2.0 !

Question, do you know what tool the AROS x86 build Icons were created with?

IcarosDesktop uses Ken's Icons. AROS 68k uses Gorilla Icons assembled at build time using ilbm2icon.

Soon we will have new colored icons based on the original set of ken's Icons.  :)

Of course I would contact him first before distributing colored icons based on the originals.

Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 04, 2023, 05:56:58 PM
Reading icOn chunk is working including Deftool & Tooltypes.  :) :) :)

I included the code for how I made it work correctly to list all the tags & values.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 04, 2023, 07:20:05 PM

Of course I would contact him first before distributing colored icons based on the originals.

That's why I created my own Icon Sets, but aren't ken's Icons DualPNG?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 04, 2023, 07:37:04 PM

Of course I would contact him first before distributing colored icons based on the originals.

That's why I created my own Icon Sets, but aren't ken's Icons DualPNG?

Yes. They are DualPNG. Some of them have two icon chunks. Though only the first is being used.
Title: Re: IconClone Icon Exchange
Post by: paolone on February 05, 2023, 04:51:17 AM
@paolone
It now has command line arguments & switches. I will add the syntax for those in the readme file.


Hi Miker and thanks for this addition. Where can I download the latest version?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 05, 2023, 05:28:03 AM
@paolone
It now has command line arguments & switches. I will add the syntax for those in the readme file.


Hi Miker and thanks for this addition. Where can I download the latest version?

I will post it here soon and also on AROS Archives.

I will also post the new usage instructions with the command line arguments and switches for IconClone.

I just need to verify that I suppressed all the test messages and that the new features work reasonably well.  8)


Title: Re: IconClone Icon Exchange
Post by: paolone on February 06, 2023, 04:30:50 AM
Thanks!
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 06, 2023, 01:42:51 PM
Thanks!

I discovered a small problem I have to fix before releasing it.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 07, 2023, 09:38:18 AM
Hello All

I have discovered three small problems with the current version of IconClone (v1.09). But it is better than the previous release and it has more functionality. There are a few workarounds.  :)

The first problem is that most of the command line options work well. We can open an empty GUI from the shell or open the GUI and display the source icon only or both the source and destination. The user then only needs to press the Exchange button. This all works correctly. But for some reason performing the icon exchange in the shell without opening the GUI fails every time. It may be a permissions problem I'm guessing. Sometimes in the shell when copying an icon it fails. It says "nothing copied. Object is in use". I will continue to work on that to find a solution.

The second problem is that the Reverse Exchange option causes stability problems after the first exchange. For example if we drop the Srce & Dest icons at the same time then perform an exchange. Then immediately perform a reverse exchange everything works. But then if we only drop the Srce or only the Dest then perform the exchange. After that the Reverse Exchange give erroneous results. So I disabled Reverse Exchange for the moment till I fix it. The symbols on the button changed to '>>' to indicate that the Exchange only goes One Way. So be sure you are sure. No going back!

The third issue is that filenames with a '.' dot cause problems. The error will be "Error loading icon. Bad file name." The solution till I fix that is in Magellan choose the icon such as "Image.png" and Rename both the file and icon to simply "Image". Magellan will copy the def icon to that location and name it to match. After that you can drop the icon as usual to perform the exchange. Rename it again to the original when done if you'd like

As with version 1.08 I will release this version as is. In a few weeks or next month when I fix those few issues I can do a small update from version 1.09 to 1.09a.

I will adjust the code for the workarounds and release it today.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 07, 2023, 01:23:30 PM
Here is the updated version 1.09 for testing. Compiled for x86. The ReadMe text file helps explain the changes.

I will test my copy for another day or two and if there are no changes I will upload it to AROS Archives.

When using Magellan the icon images that changed will not show correctly till the window or volume is re-opened. Then the new icon images will display correctly.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 07, 2023, 01:55:53 PM
Thanks miker, I will also do some testing for due diligence
Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 07, 2023, 05:53:49 PM
Miker I encountered a problem with this icon is named 1.3
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 07, 2023, 06:09:35 PM
Miker I encountered a problem with this icon is named 1.3

Because is has a '.' dot in the filename. IconClone can't handle those filenames at the moment.

Same if the filename was "Image1.png" & the icon would then be "Image1.png.info" but it won't load the icon image. Not yet.
Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 07, 2023, 06:18:12 PM
Ok Miker :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 08, 2023, 04:04:54 AM
Here is the updated version 1.09 for testing. Compiled for x86. The ReadMe text file helps explain the changes.

I will test my copy for another day or two and if there are no changes I will upload it to AROS Archives.

When using Magellan the icon images that changed will not show correctly till the window or volume is re-opened. Then the new icon images will display correctly.

Outstanding Miker, now IconClone not only replaces the image to the icons, but creates the icon if not present by picking up the Def_Icons

Example, if a volume like DH0, RAM, don't have the "Disk.info" fil in the root of the volume, on the first drag and drop, IconClone will give a "physiological" error (Disk.info missing), meanwhile it has generated in that volume the "Disk.info" file, on the second drag and drop "voila" everything will work perfectly because the Disk.info had been generated
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 09, 2023, 01:52:54 PM
Yes. It will first look for ':' for a volume name then it will append "disk.info' then it will use GetDiskObjectNew for the new filename (vol+disk.info). If GetDiskObject fails it uses GetDefDiskObject. Then it checks to see if the disk.info exists at the root of volume. If not it gives a warning. Then finally it uses PutDiskObject to copy the def_Disk icon.

I suppose the warning should be 'disk icon not found. would you like to assign one?' (YES/NO). That gives you the option to copy the def_icon instead of doing it by default.

The same is true for the drag-n-drop for drawers & files. If the drawer icon or file icon doesn't exist (it uses def_) then it will copy the def_icon to that location and load it instead. In that way you can easily assign new icons to drawers & files.

It won't work though if your file has a '.' dot in the filename such as "Image.png" & the icon name is "Image.png.info". Hopefully I will fix that in the next update for IconClone.

I believe that's a nice feature to easily assign icons. Not sure if I should leave the disk.info error message or simply remove it and copy def icons automatically then load them.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 09, 2023, 02:00:50 PM
S in fact the message is better to remove it, some users might think of a mistake, and not understand that the icon incece was already copied from the def_
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 09, 2023, 02:05:39 PM
I can remove the error message. If the user is dropping a volume disk icon then the intent is to display an icon for the icon exchange. It shouldn't matter if it's a def_icon.

So I will remove the message and copy the def_icon automatically just like other drawers & files without icons.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 09, 2023, 02:33:03 PM
The Def_HardDisk.info usually is the standard AROS icon, by defaul no AROS volume should have a Disk.info, the AROS system by default assigns the correct icon automatically based on the Volume type.

There are special cases, such as when mounting a shared, AROS assigns a Floppy Icon, unlike OS3 which instead assigns a Hardisk.info Icon

This is normal, OS3 assigns volumes the def_Disk.info, AROS instead assigns volumes the def_HardDisk.info

In this case it is solved by creating a script to copy and customize the Shared icon, as I did on AROS One.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 09, 2023, 03:00:52 PM
The Def_HardDisk.info usually is the standard AROS icon, by defaul no AROS volume should have a Disk.info, the AROS system by default assigns the correct icon automatically based on the Volume type.

There are special cases, such as when mounting a shared, AROS assigns a Floppy Icon, unlike OS3 which instead assigns a Hardisk.info Icon

This is normal, OS3 assigns volumes the def_Disk.info, AROS instead assigns volumes the def_HardDisk.info

In this case it is solved by creating a script to copy and customize the Shared icon, as I did on AROS One.

GetDiskObjectNew takes care of all that for us automatically. If you open a shell and look at the root of the AROS: volume is the file "Disk.info". That's the filename IconClone is looking for. At that point it doesn't matter which file the def_icon refers to. IconClone merely assigns and loads whichever def_icon the system returns.

But your explanation helps to understand which def_icons are for which volumes. Thanks for that information.

BTW - I have a theory about why I'm having such difficulty doing a direct icon image exchange using the command line only.

But then it may be as easy as a misplaced EraseRectangle operation to erase a portion of a non-existent rasterport for an unopened window because we are using the command line!

PS - Removing the misplaced EraseRectangle function call helped some. It no longer crashes on x86-64 when doing an icon image exchange at the command line. But there are more issues to resolve than just that to get the CLI version working.

Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 12, 2023, 04:25:09 PM
Sometimes it is better to use AROS x86-64 to develop applications because it is very precise which requires precise program code.

AROS x86 however is much more forgiving. On AROS x86 doing an icon image exchange at the commandline simply didn't work. There were no errors. It just didn't work.

On AROS x86-64 though at first the system would crash every time I tried until I realized that the Erase_Rectangle function was the culprit. Erase_Rectangle uses graphics library to draw the background color in a specified rectangle on the window rasterport. But the problem at the commandline is that you cannot erase a portion of a window that hasn't been opened.

But even after that correction the Exchange_Icon function when used at the commandline kept causing a system crash. I had been looking at the code in the function for 3 days now trying everything I possibly could to make it work. But it failed.

The solution is very easy when you think about it. The last line of code in the Exchange_Icon function was Display_Icon(destname, "right", ...). It was an Id-10-t error!

You cannot display an icon image in a user interface that hasn't been opened. That causes a horrible system crash! Now it works just fine! :-)

Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 13, 2023, 08:05:15 AM
In the next few days I will remove any test code and I'll compile it for 68k, x86 & x86-64.

This will be the final release candidate for version 1.9 of IconClone. If all goes well then I will post it on AROS Archives. And this will be the first one posted on Aminet.  :)

I work full time during the day so it's not easy to do updates.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 13, 2023, 10:38:44 AM
Thanks miker, great job ! will the 68k version be compatible with Amiga OS too ?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 13, 2023, 10:51:21 AM
Thanks miker, great job ! will the 68k version be compatible with Amiga OS too ?

The 68k version for AROS will work with OS35 icons (Glow Icons) & Amiga OS4 icons.

The binary file won't work on Amiga OS 3.x because it's compiled for AROS. As with many apps written for Amiga that work on AROS 68k but not all AROS apps work with Amiga unless they are specifically written for Amiga also.

I would like to see IconClone compiled for Amiga OS4.  8)

Maybe in the next update I can revise some of the source code to make it more compatible with compiling for Amiga.I could use the DevCPP IDE I used several years ago for Amiga OS3.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 14, 2023, 09:13:15 AM
@paolone

The command line icon exchange is now working! I will compile IconClone for x86. This will be the release candidate for the latest version.

Also -
The message that was displayed when a volume disk icon wasn't found has been removed. Now it won't prompt. It will just copy the default disk icon to that location then load it for the icon exchange. It behaves the same now as dropping a file or directory that only has a default icon. It copies it instead.

The '.' dot in filename issue is also being fixed. In Display_Icon we have to get a diskobject to view the images. If it fails to get a diskobject it prompts: "Error loading icon. Bad filename.". I was using GetDiskObject for a file such as "Image png.info". But that will fail because it's a default picture icon. So I changed it to GetDiskObjectNew which will try to get a diskobject. If that fails it uses GetDefDiskObject instead. That's what we wanted.

So hopefully the new x86 binary will be ready later today. One of the nice features of these small icon tools that I'm writing is that they can all easily be compiled in a shell with gcc.

When using IconClone with Magellan the new icon images will not be visible until you close & re-open the drawer or volume where the destination icon is located. So if you do an icon exchange & nothing seems to happen do the above. When using Wanderer the icon image changes are visible automatically within a few seconds after the icon exchange.

Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 14, 2023, 01:15:44 PM
thank you Miker
Title: Re: IconClone Icon Exchange
Post by: aha on February 14, 2023, 01:23:07 PM
@miker

I‘m looking forward to it. Thank you very much!
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 16, 2023, 05:30:44 AM
miker, I came across some icons that I can't convert, as soon as I drag the icon a Shell "CON" appears.

They seem to be Glow Icons, on OS3.9 the conversion works fine.

I attach screenshot error, and the two Icons I tried to convert:

Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 16, 2023, 09:57:35 AM
miker, I came across some icons that I can't convert, as soon as I drag the icon a Shell "CON" appears.

They seem to be Glow Icons, on OS3.9 the conversion works fine.

I attach screenshot error, and the two Icons I tried to convert:

Thanks. I will test the sample icons. I noticed the LunaPaint icon won't display with drag-n-drop but it works with file requesters (? Buttons). I will check that out as well.

It all helps IconClone to become a better icon application.

I'm still testing but I don't see anything peculiar about the icons themselves. Maybe there is something wrong with the loading & displaying functions . Not sure yet

Both of your test icons have signature 'E310' so they are Classic Amiga Icons with OS35 IFF Extension with two IMAG chunks. So in theory they should load & display. The LunaPaint icon is a single PNG icon. So it should load ok.

After investigating I find that there is an error with the filename with drag-n-drop for Templates.info. But when you use the '?' file requester it loads just fine. The other icon "TesterDecks.info" loads & displays at the command line & with drag-n-drop. No problems with that one.

I will try to reproduce the CON window error. I'll fix that.

Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 16, 2023, 05:55:44 PM
miker, I came across some icons that I can't convert, as soon as I drag the icon a Shell "CON" appears.

They seem to be Glow Icons, on OS3.9 the conversion works fine.

I attach screenshot error, and the two Icons I tried to convert:

The other icons work correctly on Magellan.

But there's something wrong with Templates.info

That icon seems corrupted. If you remake that icon with the same images it may work.
Title: Re: IconClone Icon Exchange
Post by: magorium on February 16, 2023, 09:23:34 PM
But there's something wrong with Templates.info

That icon seems corrupted. If you remake that icon with the same images it may work.
Perhaps the following output is able to help you (further) analyze the issue:
Code: [Select]
./ii dumpstructs info Templates.info
-------------------------------
           Parse Icons
-------------------------------
Path    = ""
Pattern = "Templates.info"
-------------------------------


opened stream for /media/ram/test/Templates.info
Read classic AOS Icon file ...
Trying to read struct DiskObject from offset $00000000
sizeof(self) = 78 sizeof(TStructDiskObject) = 78
Trying to read struct DrawerData from offset $0000004E
SizeOf OldDrawerData = 56
Trying to read struct Image (1) from offset $00000086
skipping 516 bytes plane-data
Trying to read struct Image (2) from offset $0000029E
skipping 552 bytes plane-data
done reading 1.0 icon
OS v2.x icon extension expected
detected data after classic AMIGA icon structures, most probably a OS 3.5 icon
exact match for OS 3.5 icon
closed stream


DiskObject:
do_Magic          : $E310
do_Version        : $0001
do_Gadget...     
.ga_NextGadget    : $00000000
.ga_LeftEdge      : 81
.ga_TopEdge       : 21
.ga_Width         : 46
.ga_Height        : 46
.ga_Flags         : $0006
.ga_Activation    : $0001
.ga_GadgetType    : 1
.ga_GadgetRender  : $ABADCAFE (See image1)
.ga_SelectRender  : $ABADCAFE (See image2)
.ga_GadgetText    : $00000000
.ga_MutualExclude : 0
.ga_SpecialInfo   : $00000000
.ga_GadgetID      : $0000
.ga_UserData      : $00000001
do_Type           : 2
do_Pad            : $00
do_DefaultTool    : $00000000
do_ToolTypes      : $00000000
do_CurrentX       : 77
do_CurrentY       : 10
do_DrawerData     : $ABADCAFE
do_ToolWindow     : $00000000
do_StackSize      : 4096

DrawerData:
dd_NewWindow... 
.nw_LeftEdge      : 381
.nw_TopEdge       : 291
.nw_Width         : 444
.nw_Height        : 217
.nw_DetailPen     : 255
.nw_BlockPen      : 255
.nw_IDCMPFlags    : $00000000
.nw_Flags         : $0200127F
.nw_Firstgadget   : $00000000
.nw_CheckMark     : $00000000
.nw_Title         : $00000000
.nw_Screen        : $00000000
.nw_BitMap        : $00000000
.nw_MinWidth      : 94
.nw_MinHeight     : 65
.nw_MaxWidth      : 65535
.nw_MaxHeight     : 65535
.nw_Type          : 1
dd_CurrentX       : -23
dd_CurrentY       : -369098753
dd_Flags          : $00000000
dd_ViewModes      : $0000

Image1:
im_LeftEdge       : 0
im_TopEdge        : 0
im_Width          : 44
im_Height         : 43
im_Depth          : 2
im_ImageData      : $ABADCAFE
im_PlanePick      : 3
im_PlaneOnOff     : 0
im_NextImage      : $00000000

Image2:
im_LeftEdge       : 0
im_TopEdge        : 0
im_Width          : 46
im_Height         : 46
im_Depth          : 2
im_ImageData      : $ABADCAFE
im_PlanePick      : 3
im_PlaneOnOff     : 0
im_NextImage      : $00000000

-------------------------------
           Statistics
-------------------------------

processed 1 files in 0.00 seconds

invalid :    0
valid   :    1
--------------- +
total   =    1

Unknown Format  :    0
OS v1.x Format  :    0
OS v2.x Format  :    0
OS v3.5 Format  :    1
NewIcon Format  :    0
PNG Format      :    0

Undefined icons :    0
Disk icons      :    0
Tool icons      :    0
Drawer icons    :    1
Project icons   :    0
Other           :    0
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 17, 2023, 01:46:41 AM

That icon seems corrupted. If you remake that icon with the same images it may work.


Yes it may be that they are damaged, strange though that with Workbench OS 3.9 you can replace them, in any case I don't use those Icons , the Glow Icons are not quality, they have bad glow and the images are poor.

On AROS One I replace all program Icons, I have already created the new DualPNG icons instead of those icons.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 17, 2023, 01:56:50 AM
@magorium

Nice icon output data.

How did you get that icon information?

Which tool did you use?
Title: Re: IconClone Icon Exchange
Post by: paolone on February 17, 2023, 02:08:13 AM
@magorium

Nice icon output data.

How did you get that icon information?

Which tool did you use?


It appears to be ii, either a linux or a sh tool. I don't know anymore about it.
Title: Re: IconClone Icon Exchange
Post by: magorium on February 17, 2023, 06:22:46 AM
@magorium

Nice icon output data.

How did you get that icon information?

Which tool did you use?
It appears to be ii, either a linux or a sh tool. I don't know anymore about it.
:)

No idea if I told already but it is my own (experimental, continuously under construction) cross-platform amiga-icon tool (ii stands for current working title: icon info).  It is actually seem to have become a never ending story for more than 12 years now  (although the source-code does not seem to account for that) :P

It is a tool that analyzes the icon structure, detects its format and dumps relevant information to the command line.

You are free to contact me if you want to have a peek at the code, it is written in Pascal though. I can provide an executable on request (provided I am able to cross-compile for the chosen target).

Unfortunately the todo list for ii is still humongous so i have never had the opportunity to do a proper release. Currently the parameter handling and implementation for the different listing modes is driving me bunkers as I never seem to be able to make up my mind. So it's a bit flaky).
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 17, 2023, 09:23:48 AM
@magorium

That's a useful little icon utility.  :)

The problem with Templates.info is what I call the icon attribute tag values such as for first image, second image, etc. AROS icon library uses ABADCAFE. Ilbmtoicon uses a numeric value. But this icon file uses an unusual value.

It can still be evaluated correctly using the rule - if it is equal to 0 then it is 0. If it is not then it's 1. And 1 means the data is present. The solution is to remake the icon file with the correct icon attribute tag values.

The problem that IconClone has with this icon is when we drag-n-drop it, the system for whatever unknown reason insists that there is a .info in the filename which is incorrect. For the appwindow there are three cases. If it's a directory the last char will be /. If it's a volume the last char is : and if it's a file it will be filename without .info extension.

IconClone as far as error handling can pick up the dot in filename which for drag-n-drop indicates "bad filename '.

But even this icon file can be displayed using the file requesters buttons '?' in the middle. Remake the icon like this. Create a new drawer with icon. Drop that in Dest display area on the right. Use Srce file requester to load Templates.info. Do the icon image exchange. In Magellan reopen the drawer or volume to display the new images.

Now the new drawer icon has icon attribute tags values ABADCAFE. We can drag-n-drop in IconClone as usual.


Title: Re: IconClone Icon Exchange
Post by: magorium on February 17, 2023, 10:35:45 AM
@magorium

That's a useful little icon utility.  :)
If interested then simply request a platform and i'll see what i can do (in which case it will not be an official release though and would be meant for internal usage only as the tool is not finished yet). For source-code feel free to pm me.

Quote
The problem with Templates.info is what I call the icon attribute tag values such as for first image, second image, etc. AROS icon library uses ABADCAFE. Ilbmtoicon uses a numeric value. But this icon file uses an unusual value.

It can still be evaluated correctly using the rule - if it is equal to 0 then it is 0. If it is not then it's 1. And 1 means the data is present. The solution is to remake the icon file with the correct icon attribute tag values.
The 'problem' with those tags/properties is that when the icon is actually loaded into memory that these tags/properties point to real memory locations where the data is actually stored.

Thus, indicating that the pointer is actually pointing toward valid data.

But, we can't actually use the original pointer values in an icon file stored on disk as the memory location where the data was loaded has no relation to the location as stored in the icon file.

One could perhaps argue that in such case it would have been nicer to let those pointers point to the actual offset in the icon file (or something to that extend) and some programs actually do something like that, but afaik that is not officially documented, nor is there any consensus on how to do that in a info file and last but not least the info file format is complicated enough as it is :)

So, any value other then 0 means data is (or should be) present and when the icon is actually loaded these values should be replaced by values of their loaded/allocated memory location.Storing an icon file simply requires to do all this in the opposite way.

Not having understood the entire problem I am a bit surprised that some programs seem to 'choke' on certain icons as the available specifications seem clear enough to me. On the other hand, that is easy for me to say because after having tested over 100.000 info files i have only managed to come across one defected icon file (and for the life of me I seem unable to figure out how to detect/handle it properly: the info file indicates that there should be data present while it actually isn't present in the file so my (pre)calculations of the info file size seem to go wrong somewhere (thus removed again from my code until further notice  :) )).

I apologize for letting the thread slide away a bit from the original topic. Any request/question/discussion specifically about my tool ii can be made in its own separate thread.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 17, 2023, 10:53:53 AM
Thanks for the information.

I've fixed the problem on my end. Not sure if it's an issue with Magellan or if it happens on Wanderer as well.

For drag-n-drop IconClone will test the filename to check for '.' dot in the name. For drag-n-drop that may have two causes, both of which are handled now. First it could have a dot such as Image.png.info or Image.bmp.info which usually indicates it uses a def icon. That's ok. But after we detect the dot in the name then we test for .info which should not be there. Otherwise it would be Templates.info.info which doesn't exist. So it will prompt with an error instead.

The solution is to use the file requester buttons which specifically returns the entire filename such as Templates.info which loads & displays correctly.

This problem happens when the system returns a bad filename.  >:(
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 17, 2023, 11:55:02 AM
IconClone version 1.09 has received many updates & improvements thanks to valuable input from users.

Though I expected to release the new version a week ago it will be just a few more days to finish the new updates.
Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 17, 2023, 11:58:10 AM
Thank's Miker :)
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 17, 2023, 02:01:15 PM
IconClone version 1.09 has received many updates & improvements thanks to valuable input from users.

Though I expected to release the new version a week ago it will be just a few more days to finish the new updates.

Thanks Miker, IconClone is getting better and better, it's worth the wait !
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 20, 2023, 10:45:30 AM
Here is the current IconClone x86 version.

It now handles correctly non-standard Classic Icons as well as icons with dot in filename such as Image.png.info which usually have def icons. The command line Exchange Icon option is also working. Instructions in ReadMe file.

Please let me know if there are any issues with this version.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 20, 2023, 11:24:48 AM
Thanks Miker, I will try as soon as possible and with pleasure this new release of IconClone !
Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 20, 2023, 11:35:37 AM
Thanks Miker :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 20, 2023, 01:14:02 PM
I'm working on another small icon app called IconPress.

It will also be released soon. Drop two images then choose Save Icon to make a new icon or assign an icon to a file or directory that has no icon. Drag-n-drop makes it easier.

Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 20, 2023, 09:18:35 PM
ok i understand Miker great!
Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 24, 2023, 04:44:10 AM
Miker you can upload to archives?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 24, 2023, 05:28:11 AM
Yes. I will do that.
Title: Re: IconClone Icon Exchange
Post by: Amiwell on February 24, 2023, 05:43:51 AM
ok Miker thanks :)
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 24, 2023, 01:35:15 PM
Here is the release version.

I will post it on AROS Archives later today.
Title: Re: IconClone Icon Exchange
Post by: miker1264 on February 24, 2023, 10:59:28 PM
I was just changing a few system icons using IconClone.  8)

I really like the graphite icons with neon blue glow border.

But I wish I had a better Black Ice window theme.  :(
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 25, 2023, 01:19:12 AM

But I wish I had a better Black Ice window theme.  :(

If you want to keep the Cat, you could copy or mix the cat image on a different black background, you can find many on the Web, an example with Glow of various colors:
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on February 25, 2023, 01:20:31 AM
More screenshots
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 25, 2023, 03:17:56 PM
Mike I hadn't tried to compile IconClone with AROS One x86, I did it now and it worked fine, do you think it may be different from what you compile on Linux?

The version i compiled with AROS One 64 ABIv11 works very well.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 25, 2023, 04:39:34 PM
Mike, I noticed that your latest version "IconClone x86_02-18-23", if you drag a Volume Icon, you have to do it 2 times before it appears in the GUI.

Instead with the version "IconClone_02-03-23" you only have to drag the Volume Icon once, to see it appear in the GUI !
Title: Re: IconClone Icon Exchange
Post by: miker1264 on March 25, 2023, 08:46:10 PM
Mike, I noticed that your latest version "IconClone x86_02-18-23", if you drag a Volume Icon, you have to do it 2 times before it appears in the GUI.

Instead with the version "IconClone_02-03-23" you only have to drag the Volume Icon once, to see it appear in the GUI !

I will check the two versions.

I have noticed on AROS One x86 sometimes I have to drag the icon more than once before it drops and appears.

On Icaros using Magellan it works great every time. I will do some more testing with Native vs Hosted.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 26, 2023, 04:00:25 AM
miker i also noticed that IconClone does not run from Shell, and the icon must be of Type "WB".

The def_Tool.info of AROS but also Amiga includes that parameter "TOOL" "CLI", so if IconClone is run with the "def_Tool.info Icon", or from SHELL, IconClone will not start
Title: Re: IconClone Icon Exchange
Post by: miker1264 on March 26, 2023, 04:53:02 PM
miker i also noticed that IconClone does not run from Shell, and the icon must be of Type "WB".

The def_Tool.info of AROS but also Amiga includes that parameter "TOOL" "CLI", so if IconClone is run with the "def_Tool.info Icon", or from SHELL, IconClone will not start

I thought you said it works great.  ;)

There is a ReadMe text file in the release package you should read.

Assign an icon to IconClone then use it from Workbench. Or use it in a shell with the correct arguments and switches. Opening it from a def_tool icon is not recommended nor has it been tested by me.

In the shell "IconClone" by itself does nothing. Likewise "IconClone icon.info" also does not work. Wrong number of arguments. However "IconClone icon1.info icon2.info" will perform the icon exchange at the command line.

There are two switches --h & --o (note that they have double dashes). The 'h' is for help. The 'o' is for open.

At the command line "IconClone --o" will open the empty GUI ready for drag-n-drop. "IconClone --o icon1.info"  will open the GUI and display the source icon. "IconClone --o icon1.info icon2.info" will open the GUI and display both images ready for the icon exchange.

If the images fail to display using drag-n-drop for whatever reason simply use the file requester buttons ( ? ).

There are two instances when file requesters are useful and opening from shell is useful. If you are trying to load disk.info and you can't see it use the file requester or type "IconClone --o disk1.info disk.info" where disk1.info is the source for new images and disk.info receives them.

To make things easier for testing I simply copy the binary file of IconClone to Ram Disk then in a shell "IconClone --o". Then no app icon is required and Printf statements can provide feedback in the shell for debugging.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 26, 2023, 05:08:57 PM
Ok thank you Miker sorry, it was the first time I got an executable not working from a Shell, it reminded me of the old Windows :)

Ok, the drag and drop difference between Magellan and Wanderer, you mentioned I don't know, maybe it will depend on the type of Icons.

It should be the other way around, it is well known that Magellan suffers with icons, on OS3 Magellan suffers it becomes very slow when it has to handle many icons in a folder.

Did you check the difference between the two versions I pointed out?

Just curious, the versions of IconClone I compiled on AROS One, both 68k and v11, the resulting files are slightly smaller "few Bytes" compared to your
Title: Re: IconClone Icon Exchange
Post by: miker1264 on March 26, 2023, 07:32:05 PM

Ok, the drag and drop difference between Magellan and Wanderer, you mentioned I don't know, maybe it will depend on the type of Icons.

It should be the other way around, it is well known that Magellan suffers with icons, on OS3 Magellan suffers it becomes very slow when it has to handle many icons in a folder.

Did you check the difference between the two versions I pointed out?

Just curious, the versions of IconClone I compiled on AROS One, both 68k and v11, the resulting files are slightly smaller "few Bytes" compared to your


I will check the differences with drag-n-drop between versions. I suspect it may have something to do with the way Wanderer and Magellan work. I'm curious if the newer IconClone code has a similar issue with the older x86-64. So I will compile for that target and start testing there.

I'd like to at least identify any potential problem though I probably won't make any changes till next time. The x86 release candidate is still the sources from 02-18-23.

I wouldn't worry about different file sizes. The binary file for x86 will not be the same size as for 68k or x86-64. The size may also vary between x86-64 ABIv1 & ABIv11 binaries.

Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 27, 2023, 12:16:56 AM
I was not referring to the difference between different versions but to the same version example:

Your version "IconClone x86_02-18-23" -> 45,608 bytes

Version compiled with AROS One x86 "IconClone x86_02-18-23" -> 44,596 bytes
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on March 27, 2023, 06:24:34 AM
My Friend PeterK has created two interesting icon utilities "LessPensForWBStartup" (latest posts), which Dopus Magellan doesn't like :o

https://eab.abime.net/showthread.php?t=64079&page=202
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on April 06, 2023, 02:14:48 PM
miker I tried to compile IconClone with GCC on OS3, ando I got errors.

Is there anything that allows you to convert "C" AROS sources to "C" OS3 sources?
Title: Re: IconClone Icon Exchange
Post by: miker1264 on April 06, 2023, 02:18:34 PM
miker I tried to compile IconClone with GCC on OS3, ando I got errors.

Is there anything that allows you to convert "C" AROS sources to "C" OS3 sources?

It won't work on Amiga OS3 the way it is currently written. It users some AROS-specific libraries and functions.

In a future version I will make it more Amiga friendly so that it can be compiled for Amiga OS3/4.
Title: Re: IconClone Icon Exchange
Post by: AMIGASYSTEM on April 06, 2023, 02:24:23 PM
Thanks, i was just curious if there was some kind of converter :)