Wanderer Icon Exchange

miker1264 · 17965

AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #135 on: December 28, 2021, 10:46:18 AM
With Magellan, things are more complicated because Dopus5 gets in the way and can confuse things even more. It has the same problems as Wanderer, after swapping images, the icon deactivates as soon as you right-click mouse.

Folders can't be swapped, plus Magellan doesn't store the saved icon position, Wanderer is ahead here with automatic positioning

AROS One that you are using includes the old Core, it doesn't change much but some old problems may have been fixed on Wanderer.
« Last Edit: December 28, 2021, 11:13:05 AM by AMIGASYSTEM »



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #136 on: December 28, 2021, 11:19:24 AM
With Magellan, things are more complicated because Dopus5 gets in the way and can confuse things even more. It has the same problems as Wanderer, after swapping images, the icon deactivates as soon as you right-click mouse.

Folders can't be swapped, plus Magellan doesn't store the saved icon position, Wanderer is ahead here with automatic positioning

AROS One that you are using includes the old Core, it doesn't change much but some old problems may have been fixed on Wanderer.

As I mentioned AROS 32bit appends a '/' to the end of associated folder names but IconClone expects just a filename without .info extension. So I have to allow for that then it works. I will revise the code to look for '/' and remove it then add ".info".

There seems to be something odd about the defPicture.info file on AROS One. When I replace it with the one from IcarosDesktop then it works as expected. Custom icons can be an issue also.

Post a sample icon that you say "deactivates" after a given time so I can test it to find out why that may happen.





AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #137 on: December 28, 2021, 12:34:52 PM
Made a small video with the "AROS-20180415-2-pc-i386" and the same thing happens as with AROS One x86, after a change of icon the icon once activated turns off deactivates alone, as if the left mouse button pressed by itself, this also happens with Magellan although more rarely, later I will try other Mouse just to verify.

Here is the video:

https://drive.google.com/file/d/14DdnnCQtSno7BsB44wJ46-_7L_Vy2ZRJ/view



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #138 on: December 28, 2021, 01:12:03 PM
Made a small video with the "AROS-20180415-2-pc-i386" and the same thing happens as with AROS One x86, after a change of icon the icon once activated turns off deactivates alone, as if the left mouse button pressed by itself, this also happens with Magellan although more rarely, later I will try other Mouse just to verify.

Here is the video:

https://drive.google.com/file/d/14DdnnCQtSno7BsB44wJ46-_7L_Vy2ZRJ/view

You have the window open when exchanging icons. After the exchange you must close it and re-open it. Or go up one to parent then back down again to refresh the icon display. That's the same on AROS x86_64. You have to refresh the icons.




AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #139 on: December 28, 2021, 02:03:27 PM
Yes on the hardisk you solve in that way, if instead the icons are found in the RAM also to close the window the problem remains


AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #140 on: December 28, 2021, 02:31:49 PM
Regarding the Hardisk you solve totally the problem increasing the stack in the Tooltype Icon
« Last Edit: December 28, 2021, 02:36:00 PM by AMIGASYSTEM »



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #141 on: December 28, 2021, 03:12:39 PM
Regarding the Hardisk you solve totally the problem increasing the stack in the Tooltype Icon

The DualPNG Icon that is produced is exactly the same as the source icon except the 'icOn' chunk. But the attributes in the chunk should be copied over as well from the destination icon.

I don't have icon display problems on my end. Increase stacksize in destination icon and make sure it copies correctly.



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #142 on: December 28, 2021, 03:50:14 PM
No, I increased the stack on the Icon of IconClone with the value 12000 the problem automatic deactivation is solved if the icons are on HD, if the icons to swap are in RAM the problem remains.


miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #143 on: December 28, 2021, 04:01:54 PM
No, I increased the stack on the Icon of IconClone with the value 12000 the problem automatic deactivation is solved if the icons are on HD, if the icons to swap are in RAM the problem remains.

Is this on AROS 68k or AROS x86 or something else? Amiga?

IconClone is not recommended for AROS 68k. There are other tools available to exchange icons on AROS 68k. Not needed.




AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #144 on: December 28, 2021, 04:20:28 PM
With AROS One 68k it doesn't happen on HD, it only happens on RAM !


AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #145 on: December 28, 2021, 04:36:02 PM
I've tested "IconClony" on AROS One 68k and I haven't found any problem both on HD and RAM.


miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #146 on: December 28, 2021, 06:37:09 PM
With AROS One 68k it doesn't happen on HD, it only happens on RAM !

I'll try to duplicate the problem.

In the meantime I have solved the problem of drag-n-drop folders. There is the trailing slash '/' that must be removed. Then there are two types of "drawers" - one with an actual icon and the other with "no icon". The latter is represented by a "def drawer". The def icon doesn't exist but you can drag-n-drop it.

So if the drawer doesn't exist how can we display it or copy it? Just like we do when we use a file requester to open an unassociated file that gets assigned a "def icon" we do the same. Instead of "GetDiskObject" we use "GetDiskObjectNew" which works like this. If the icon exists we will use it. If not we get a default icon instead but that's just a Disk Object. What about the icon file. Now we test for the icon. Remember if it exists we used it. So it may be there or not. If we are using a def icon the icon file does not exist. For display purposes we use PutDiskObject to write the def icon to disk as our filename.

Now the default drawer icon exists and we can display it.  ;)



miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #147 on: December 28, 2021, 10:43:59 PM
Now that IconClone can handle standard icons as well as def icons including def tools and def drawers what would allow it to earn a reputation as best icon copier for high quality icons?

If we could simply drop an OS4.1 PowerIcon or an AROS Hybrid Icon on the source display area and have them immediately converted to PNG Icons from which to clone images that would be quite nice! The ability to clone OS4.1 icons into PNG icons.

I'm working on that as well as displaying & cloning OS3.5 icons.

« Last Edit: December 28, 2021, 10:48:41 PM by miker1264 »



AMIGASYSTEM

  • Global Moderator
  • Legendary Member
  • *****
    • Posts: 3740
    • Karma: +69/-2
  • AROS One
    • AROS One
Reply #148 on: December 29, 2021, 04:52:14 AM
Ok thanks miker, about the problem icon on/off I think it depends on the fact that the icon remains in use by IconClone, in fact the swapped icons can not be deleted "file in use".


miker1264

  • Legendary Member
  • *****
    • Posts: 1827
    • Karma: +84/-6
Reply #149 on: December 29, 2021, 07:30:43 AM
Ok thanks miker, about the problem icon on/off I think it depends on the fact that the icon remains in use by IconClone, in fact the swapped icons can not be deleted "file in use".

That seems plausible.

Here is the revised version which allows drag-n-drop of folders. It was tested and is working with IcarosDesktop 32bit.

I had some problems with AROS One x86 v1.6 icon.library. It didn't like "GetDiskObjectNew" for some odd reason. So I replaced it with icon.library for IcarosDesktop. Now it works.

Please test this with dropping folders on AROS One x86. Let me know if it works.

« Last Edit: December 29, 2021, 03:19:28 PM by miker1264 »